Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Tappable): force activated/hovered state (#7906) #7910

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix(Tappable): force activated/hovered state (#7906) #7910

merged 1 commit into from
Nov 7, 2024
+44 −36

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Nov 7, 2024 •
edited by inomdzhon
Loading

Release notes

Исправления

  • Tappable: вернули работу hasActive свойства, исправили отсутствие activated-состояния при некоторых условиях

@BlackySoul BlackySoul requested a review from a team as a code owner November 7, 2024 10:53
@BlackySoul BlackySoul added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

size-limit report 📦

Path Size
JS 385.45 KB (-0.03% 🔽)
JS (gzip) 116.55 KB (-0.02% 🔽)
JS (brotli) 95.72 KB (+0.05% 🔺)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 331.15 KB (0%)
CSS (gzip) 41.35 KB (0%)
CSS (brotli) 32.69 KB (0%)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

👀 Docs deployed

Commit 91bf3e9

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.15%. Comparing base (66405d2) to head (91bf3e9).
Report is 19 commits behind head on v6.

Additional details and impacted files 
@@            Coverage Diff             @@
##               v6    #7910      +/-   ##
==========================================
- Coverage   95.20%   95.15%   -0.05%     
==========================================
  Files         383      383              
  Lines       11340    11356      +16     
  Branches     3723     3742      +19     
==========================================
+ Hits        10796    10806      +10     
- Misses        544      550       +6
Flag Coverage Δ
unittests 95.15% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon added this to the v6.7.4 milestone Nov 7, 2024
inomdzhon
inomdzhon approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ps: добавил milestone и Release notes в описание

@BlackySoul BlackySoul merged commit 6f41df4 into v6 Nov 7, 2024
27 of 28 checks passed
@BlackySoul BlackySoul deleted the patch/pr7906 branch November 7, 2024 17:17
vkcom-publisher pushed a commit that referenced this pull request Nov 7, 2024
@BlackySoul @actions-user
fix(Tappable): force activated/hovered state (#7906) (#7910)
f493943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees
No one assigned
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Milestone
v6.7.4
Development

Successfully merging this pull request may close these issues.
3 participants
@BlackySoul @inomdzhon @andrey-medvedev-vk